Back

deno #32062

fix(ext/node): emit error event for worker with missing main module

by littledivy · Feb 06, 2026 at 19:36 UTC · scan-0577e45eb8c098f4

View on Github · Download JSON
Low Risk (0%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: Low (0%)

Intent

3/3 criteria met

Emit error event for worker with missing main module

Acceptance Criteria

  • ✓
    Test for worker with missing main module is fixed

    tests/node_compat/config.jsonc adds missing test

  • ✓
    Error for missing main module is handled

    runtime/web_worker.rs adds bootstrap_error field

  • ✓
    Legacy test for non-existent file is removed

    tests/unit_node/worker_threads_test.ts removes test

Confidence: 95.0% Source: diff analysis AI: openai

Contributors

littledivy PR Author 7 commits + Trusted
Account Age: 2958 days
Prior PRs: 962
Merged: 808

Trusted contributor with 808 merged PRs. maintains 367 public repositories. has 597 followers. unfamiliar with ext/node/ops/worker_threads.rs.

bartlomieju 1 commit + Trusted
Account Age: 3842 days
Prior PRs: 2583
Merged: 2211

Trusted contributor with 2211 merged PRs. maintains 92 public repositories. has 1064 followers.

Evidence

Evidence Completeness: 70.0%
tests_passing Failing
lint_passing Passing
ci_passing Passing
build_successful Passing
Missing: security_scan_clean, coverage_maintained

Supply Chain

None Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts

Focus Files

Review 4 file(s)

runtime/web_worker.rs +60

60 lines changed; Source code

medium
ext/node/ops/worker_threads.rs +14

Source code

medium
tests/unit_node/worker_threads_test.ts +11

Source code

medium
tests/node_compat/config.jsonc +1

Standard file

low

Triage

21

minutes to review

medium

effort level

none

staleness risk

Standard review process

Recommendation

APPROVE 83.0% readiness

Good evidence, acceptable risk, ready for merge

Next Steps

Question

Why is security_scan_clean missing? Consider adding this check.

Question

Why is coverage_maintained missing? Consider adding this check.