Back

langchain #34309

chore(langchain): add overloads to `create_agent`

by cbornet · Feb 06, 2026 at 19:31 UTC · scan-1ca53528708c5869

View on Github · Download JSON
Low Risk (20%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: Low (20%)

Risk Drivers

  • api_surface_change: API surface changed in 1 file(s)

Intent

2/3 criteria met

Add overloads to `create_agent` for better mypy type inference.

Non-Goals

  • - Change functionality of `create_agent`
  • - Refactor entire type system
  • - Add new features beyond type changes

Acceptance Criteria

  • ✓
    Overloads are added to `create_agent`.

    Added `overload` in `factory.py`.

  • ✓
    Enable mypy inference without `ResponseT`.

    Overloads help in type inference enhancement in `factory.py`.

  • ?
    Related typing changes should not break existing functionality.

    No evidence of broken functionality, but tests changes slightly in `test_shell_tool_integration.py`.

Confidence: 90.0% Source: pr description AI: openai

Contributors

cbornet PR Author 1 commit + Trusted
Account Age: 3972 days
Prior PRs: 442
Merged: 398

Trusted contributor with 398 merged PRs. maintains 129 public repositories. has 177 followers.

Evidence

Evidence Completeness: 80.0%
ci_passing Passing
tests_passing Passing
lint_passing Passing
build_successful Passing
Missing: security_scan_clean, coverage_maintained

Supply Chain

None Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts

Focus Files

Review 1 high-priority file(s)

libs/langchain_v1/langchain/agents/factory.py +78

78 lines changed; Source code

high
libs/langchain_v1/tests/integration_tests/agents/middleware/test_shell_tool_integration.py +12

Source code

medium
libs/langchain_v1/langchain/agents/middleware/types.py +4

Source code

medium

Triage

20

minutes to review

medium

effort level

none

staleness risk

Standard review process

Recommendation

APPROVE 81.0% readiness

Good evidence, acceptable risk, ready for merge

Next Steps

Question

Why is security_scan_clean missing? Consider adding this check.

Question

Why is coverage_maintained missing? Consider adding this check.