Back

uv #17455

Support using `--index` to refer to index names

by EliteTK · Feb 06, 2026 at 19:07 UTC · scan-5eeb51c11f4b75d7

View on Github · Download JSON
Critical Risk (100%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: Critical (100%)

Risk Drivers

  • large_diff: Large change: 2091 lines modified
  • high_file_spread: Touches 21 files
  • multiple_concerns: Spans 9 directories
  • cross_concern_spread: Touches 3 functional domains: configuration, documentation, testing
  • api_surface_change: API surface changed in 3 file(s)

Intent

5/5 criteria met

Support using --index to refer to index names in CLI.

Non-Goals

  • - Support --default-index by name

Acceptance Criteria

  • ✓
    Implement #13974

    pr_description mentions it implements #13974

  • ✓
    Add IndexArg type for CLI

    crates/uv-distribution-types/src/index.rs adds IndexArg

  • ✓
    Error handling with exit(2)

    pr_description discusses replacing Result with exit(2)

  • ✓
    New Resolve trait

    pr_description explains changes in PipOptions requiring a new trait

  • ✓
    Argument cross-reference checks

    pr_description and comments in options.rs reflect this logic

Confidence: 95.0% Source: pr description AI: openai

Contributors

EliteTK PR Author 27 commits + Trusted
Account Age: 4668 days
Prior PRs: 24
Merged: 19

Trusted contributor with 19 merged PRs. maintains 85 public repositories. unfamiliar with 9 files being modified.

zanieb 1 commit + Trusted
Account Age: 4859 days
Prior PRs: 2029
Merged: 1787

Trusted contributor with 1787 merged PRs. maintains 116 public repositories. has 908 followers.

Evidence

Evidence Completeness: 50.0%
ci_passing Unavailable
build_successful Unavailable
tests_passing Failing
lint_passing Passing
Missing: security_scan_clean, coverage_maintained

Supply Chain

Low Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts

Focus Files

Review 6 high-priority file(s)

crates/uv-cli/src/options.rs +231

231 lines changed; Source code

high
crates/uv-distribution-types/src/index.rs +222

222 lines changed; Source code

high
crates/uv/src/lib.rs +170

170 lines changed; Source code

high
crates/uv/src/settings.rs +211

211 lines changed; Source code

high
crates/uv/tests/it/edit.rs +773

773 lines changed; Source code

high
crates/uv/tests/it/lock.rs +100

100 lines changed; Source code

high
crates/uv/tests/it/run.rs +70

70 lines changed; Source code

medium
crates/uv/tests/it/sync.rs +69

69 lines changed; Source code

medium
crates/uv-settings/src/settings.rs +58

58 lines changed; Source code

medium
crates/uv/tests/it/tool_install.rs +61

61 lines changed; Source code

medium

+11 more files

Triage

240

minutes to review

extensive

effort level

none

staleness risk

Schedule dedicated review time; consider pair review

Recommendation

REQUEST CHANGES 45.0% readiness

Critical risk level requires changes before approval

Next Steps

Concern

Consider breaking into smaller PRs

Question

Why is security_scan_clean missing? Consider adding this check.

Question

Why is coverage_maintained missing? Consider adding this check.