Back

ollama #14108

feat: add PARAMETER think support for Modelfile

by sanchez314c · Feb 06, 2026 at 19:33 UTC · scan-65ee860feb5ae5e4

View on Github · Download JSON
Medium Risk (40%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: Medium (40%)

Risk Drivers

  • new_contributor: First contribution from sanchez314c
  • missing_tests: Added 62 lines of code but only 0 lines of tests

Intent

4/4 criteria met

Add support for specifying a default 'think' parameter in Modelfiles.

Acceptance Criteria

  • ✓
    Support for PARAMETER think in Modelfiles.

    parser/parser.go handles 'think' parameter parsing.

  • ✓
    Request-level think overrides model-level think.

    server/routes.go checks req.Think before model parameter.

  • ✓
    Models without PARAMETER think behave as before.

    cmd/cmd.go ensures default behavior remains unchanged.

  • ✓
    API/CLI can override model PARAMETER think.

    Test Matrix shows overriding works.

Confidence: 95.0% Source: pr description AI: openai

Contributors

sanchez314c PR Author 1 commit ? New Contributor
Account Age: 573 days
Prior PRs: 1

First-time contributor to this repository. unfamiliar with 3 files.

Evidence

Evidence Completeness: 0.0%
Missing: ci_passing, tests_passing, lint_passing, security_scan_clean, coverage_maintained, build_successful

Supply Chain

None Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts

Focus Files

Review 3 file(s)

cmd/cmd.go +25

Source code

medium
server/routes.go +22

Source code

medium
parser/parser.go +15

Source code

medium

Triage

17

minutes to review

medium

effort level

none

staleness risk

Standard review process

Recommendation

NEEDS DISCUSSION 28.0% readiness

Insufficient evidence (CI/tests) to evaluate

Next Steps

Question

Why is ci_passing missing? Consider adding this check.

Question

Why is tests_passing missing? Consider adding this check.

Nitpick

First contribution - consider welcoming and providing extra context