Back

deno #32067

fix(ext/node): propogate stdio errors during worker init

by littledivy · Feb 06, 2026 at 19:40 UTC · scan-9ceca10efc21263b

View on Github · Download JSON
Low Risk (0%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: Low (0%)

Intent

3/3 criteria met

Propagate stdio errors during worker initialization and handle panics as JS errors.

Acceptance Criteria

  • ✓
    Fix `test-worker-init-failure.js` test

    tests/node_compat/config.jsonc includes new test entry for `test-worker-init-failure.js`

  • ✓
    Prevent immediate exit inside panic handler to allow handling by the host thread

    cli/main.rs modifies exit behavior in `setup_panic_hook`

  • ✓
    Report failed stdio setup as a JS error

    ext/io/lib.rs adds error handling in stdio setup

Confidence: 95.0% Source: pr description AI: openai

Contributors

littledivy PR Author 3 commits + Trusted
Account Age: 2958 days
Prior PRs: 962
Merged: 808

Trusted contributor with 808 merged PRs. maintains 367 public repositories. has 597 followers.

Evidence

Evidence Completeness: 60.0%
tests_passing Failing
ci_passing Passing
build_successful Passing
lint_passing Unavailable
Missing: security_scan_clean, coverage_maintained

Supply Chain

None Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts

Focus Files

Review 4 file(s)

ext/io/lib.rs +64

64 lines changed; Source code

medium
cli/main.rs +9

Source code

medium
runtime/ops/worker_host.rs +4

Source code

medium
tests/node_compat/config.jsonc +1

Standard file

low

Triage

20

minutes to review

medium

effort level

none

staleness risk

Standard review process

Recommendation

APPROVE 79.0% readiness

Good evidence, acceptable risk, ready for merge

Next Steps

Question

Why is security_scan_clean missing? Consider adding this check.

Question

Why is coverage_maintained missing? Consider adding this check.