Back

langchain #34249

chore(langchain): activate mypy `warn_return_any`

by cbornet · Feb 06, 2026 at 19:31 UTC · scan-aa6a9c2b4de9f862

View on Github · Download JSON
Medium Risk (35%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: Medium (35%)

Risk Drivers

  • missing_tests: Added 272 lines of code but only 0 lines of tests
  • api_surface_change: API surface changed in 2 file(s)

Intent

2/3 criteria met

Activate mypy's `warn_return_any` to ensure type safety

Acceptance Criteria

  • ✓
    Mypy `warn_return_any` directive is active

    Changes in return types in factory.py, shell_tool.py reflect mypy compliance

  • ✓
    Return types are specified where missing

    Return types added in middleware/types.py and structured_output.py

  • ?
    Code remains functional and compilable

    No functional tests or output validation in the diff

Confidence: 90.0% Source: diff analysis AI: openai

Contributors

cbornet PR Author 2 commits + Trusted
Account Age: 3972 days
Prior PRs: 442
Merged: 398

Trusted contributor with 398 merged PRs. maintains 129 public repositories. has 177 followers.

Evidence

Evidence Completeness: 80.0%
ci_passing Passing
tests_passing Passing
lint_passing Passing
build_successful Passing
Missing: security_scan_clean, coverage_maintained

Supply Chain

Low Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts

Focus Files

Review 1 high-priority file(s)

libs/langchain_v1/langchain/agents/middleware/types.py +434

434 lines changed; Source code

high
libs/langchain_v1/langchain/agents/structured_output.py +8

Source code

medium
libs/langchain_v1/langchain/chat_models/base.py +10

Source code

medium
libs/langchain_v1/langchain/agents/factory.py +6

Source code

medium
libs/langchain_v1/langchain/agents/middleware/shell_tool.py +2

Source code

medium
libs/langchain_v1/pyproject.toml +3

Configuration

low

Triage

63

minutes to review

high

effort level

none

staleness risk

Allocate focused review time

Recommendation

APPROVE 77.0% readiness

Good evidence, acceptable risk, ready for merge

Next Steps

Question

Why is security_scan_clean missing? Consider adding this check.

Question

Why is coverage_maintained missing? Consider adding this check.