Back

deno #31974

fix: support loading `npm:` and `jsr:` specifiers in required ES modules

by dsherret · Feb 06, 2026 at 19:39 UTC · scan-c4e82ce3892cf2d2

View on Github · Download JSON
Medium Risk (35%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: Medium (35%)

Risk Drivers

  • multiple_concerns: Spans 7 directories
  • api_surface_change: API surface changed in 2 file(s)

Intent

3/3 criteria met

Support loading npm: and jsr: specifiers in required ES modules

Acceptance Criteria

  • ✓
    Support npm: and jsr: specifiers in required ES modules

    cli/module_loader.rs changes include handling for npm: and jsr: specifiers

  • ✓
    Update dependencies appropriately

    Cargo.toml and Cargo.lock version increments

  • ✓
    Include tests for new functionality

    New tests in tests/specs/run/require_esm_npm_jsr/*

Confidence: 95.0% Source: diff analysis AI: openai

Contributors

dsherret PR Author 12 commits + Trusted
Account Age: 5057 days
Prior PRs: 1805
Merged: 1737

Trusted contributor with 1737 merged PRs. maintains 166 public repositories. has 2061 followers. unfamiliar with 6 files being modified.

Evidence

Evidence Completeness: 80.0%
tests_passing Passing
lint_passing Passing
ci_passing Passing
build_successful Passing
Missing: security_scan_clean, coverage_maintained

Supply Chain

Low Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts

Focus Files

Review 2 high-priority file(s)

libs/resolver/file_fetcher.rs +221

221 lines changed; Source code

high
tests/specs/run/require_esm_npm_jsr/sync.js +4

New file; Source code

high
cli/module_loader.rs +61

61 lines changed; Source code

medium
cli/graph_util.rs +25

Source code

medium
ext/node/polyfills/01_require.js +5

Source code

medium
tests/specs/run/require_esm_npm_jsr/deno.json +5

New file; Configuration

medium
cli/graph_container.rs +1

Source code

medium
cli/tools/bundle/mod.rs +1

Source code

medium
cli/tools/pm/deps.rs +1

Source code

medium
runtime/worker.rs +2

Source code

medium

+5 more files

Triage

67

minutes to review

high

effort level

none

staleness risk

Allocate focused review time

Recommendation

APPROVE 77.0% readiness

Good evidence, acceptable risk, ready for merge

Next Steps

Question

Why is security_scan_clean missing? Consider adding this check.

Question

Why is coverage_maintained missing? Consider adding this check.

Concern tests/specs/run/require_esm_npm_jsr/sync.js

New file in high-priority area: New file; Source code