Back

deno #32058

fix(install): cleanup `node_modules` folder on install

by dsherret · Feb 06, 2026 at 19:40 UTC · scan-d7bee555ba779c5a

View on Github · Download JSON
Critical Risk (85%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: Critical (85%)

Risk Drivers

  • large_diff: Large change: 1172 lines modified
  • high_file_spread: Touches 30 files
  • multiple_concerns: Spans 10 directories
  • api_surface_change: API surface changed in 3 file(s)

Intent

3/3 criteria met

Clean up the `node_modules` folder during `deno install/add/remove`.

Non-Goals

  • - Apply cleanup to other commands beyond install/add/remove
  • - Handle simultaneous deno subprocesses
  • - Improving startup time for all commands

Acceptance Criteria

  • ✓
    Cleanup `node_modules` on install

    cli/factory.rs and libs/npm_installer/local.rs add `clean_on_install` flag.

  • ✓
    Does not affect other commands

    PR description states it's only for install/add/remove.

  • ✓
    No startup delay addition

    Cleanup implemented conditional to install-related operations only.

Confidence: 95.0% Source: pr description AI: openai

Contributors

dsherret PR Author 13 commits + Trusted
Account Age: 5057 days
Prior PRs: 1805
Merged: 1737

Trusted contributor with 1737 merged PRs. maintains 166 public repositories. has 2061 followers. unfamiliar with 5 files being modified.

Evidence

Evidence Completeness: 80.0%
lint_passing Passing
tests_passing Passing
ci_passing Passing
build_successful Passing
Missing: security_scan_clean, coverage_maintained

Supply Chain

Low Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts
New dependencies: cowsay, chalk

Focus Files

Review 5 high-priority file(s)

libs/npm_cache/fs_util.rs +111

111 lines changed; Source code

high
libs/npm_installer/bin_entries.rs +137

137 lines changed; Source code

high
libs/npm_installer/local.rs +446

446 lines changed; Source code

high
cli/tools/clean.rs +90

90 lines changed; Source code

high
libs/npm_installer/fs.rs +88

88 lines changed; Source code

high
cli/util/fs.rs +55

55 lines changed; Source code

medium
cli/factory.rs +49

Source code

medium
libs/npm_installer/lib.rs +30

Source code

medium
libs/npm_installer/bin_entries/windows_shim.rs +18

Source code

medium
cli/npm.rs +8

Source code

medium

+20 more files

Triage

173

minutes to review

extensive

effort level

none

staleness risk

Schedule dedicated review time; consider pair review

Recommendation

REQUEST CHANGES 61.0% readiness

Critical risk level requires changes before approval

Next Steps

Concern

Consider breaking into smaller PRs

Question

Why is security_scan_clean missing? Consider adding this check.

Question

Why is coverage_maintained missing? Consider adding this check.

Suggestion

Verify new dependencies: cowsay, chalk