Back

langchain #34435

style(langchain): add ruff rules ARG

by cbornet · Feb 06, 2026 at 19:31 UTC · scan-dfa8fe517116489e

View on Github · Download JSON
Medium Risk (40%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: Medium (40%)

Risk Drivers

  • high_file_spread: Touches 23 files
  • api_surface_change: API surface changed in 5 file(s)

Intent

3/4 criteria met

Enhance style consistency by applying specific ruff rules

Acceptance Criteria

  • ✓
    Use @override for parent method overrides

    test_decorators.py adds 'override' import

  • ✓
    Prefix renamable parameters with _

    test_composition.py changes parameter name to _

  • ?
    Use *_args, **_kwargs when renaming is not possible

    No changes showing *_args or **_kwargs

  • ✓
    Use _ = variable when the name is inspected

    test_tools.py uses _ = value

Confidence: 90.0% Source: pr description AI: openai

Contributors

cbornet PR Author 1 commit + Trusted
Account Age: 3972 days
Prior PRs: 442
Merged: 398

Trusted contributor with 398 merged PRs. maintains 129 public repositories. has 177 followers. unfamiliar with libs/langchain_v1/tests/unit_tests/agents/middleware_typing/test_middleware_typing.py.

Evidence

Evidence Completeness: 80.0%
ci_passing Passing
tests_passing Passing
build_successful Passing
lint_passing Passing
Missing: security_scan_clean, coverage_maintained

Supply Chain

Low Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts

Focus Files

Review 23 file(s)

libs/langchain_v1/tests/unit_tests/agents/test_system_message.py +66

66 lines changed; Source code

medium
libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_framework.py +35

Source code

medium
libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_decorators.py +24

Source code

medium
libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_composition.py +8

Source code

medium
libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_tools.py +12

Source code

medium
libs/langchain_v1/tests/unit_tests/agents/test_create_agent_tool_validation.py +12

Source code

medium
libs/langchain_v1/tests/unit_tests/agents/middleware/core/test_wrap_tool_call.py +4

Source code

medium
libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_human_in_the_loop.py +4

Source code

medium
libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_model_retry.py +4

Source code

medium
libs/langchain_v1/tests/unit_tests/agents/middleware/implementations/test_shell_tool.py +4

Source code

medium

+13 more files

Triage

71

minutes to review

extensive

effort level

none

staleness risk

Schedule dedicated review time; consider pair review

Recommendation

APPROVE 75.0% readiness

Good evidence, acceptable risk, ready for merge

Next Steps

Question

Why is security_scan_clean missing? Consider adding this check.

Question

Why is coverage_maintained missing? Consider adding this check.