Back

deno #32073

feat: npm overrides

by dsherret · Feb 06, 2026 at 19:40 UTC · scan-ebf7eaf1b54bb798

High Risk (55%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: High (55%)

Risk Drivers

  • multiple_concerns: Spans 7 directories
  • touches_configuration: Modifies configuration code
  • api_surface_change: API surface changed in 2 file(s)

Intent

3/3 criteria met

Introduce npm overrides handling functionality.

Acceptance Criteria

  • โœ“
    Implement npm overrides reading from package.json

    libs/config/workspace/mod.rs adds npm_overrides method

  • โœ“
    Modify resolver to accommodate overrides

    cli/lsp/language_server.rs and resolver.rs update NpmVersionResolver

  • โœ“
    Add related tests for overrides feature

    New files in tests/specs/npm/overrides verify functionality

Confidence: 95.0% Source: diff analysis AI: openai

Contributors

dsherret PR Author 6 commits + Trusted
Account Age: 5057 days
Prior PRs: 1805
Merged: 1737

Trusted contributor with 1737 merged PRs. maintains 166 public repositories. has 2061 followers. unfamiliar with 4 files being modified.

Evidence

Evidence Completeness: 30.0%
ci_passing Unavailable
build_successful Unavailable
lint_passing Unavailable
Missing: tests_passing, security_scan_clean, coverage_maintained

Supply Chain

Low Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts
New dependencies: @denotest/different-nested-dep, @denotest/different-nested-dep-child

Focus Files

Focus on 1 critical file(s)

libs/config/workspace/mod.rs +59

Modifies configuration code; 59 lines changed; Source code

critical
test_overrides_manual/main.ts +2

New file; Source code

high
tests/specs/npm/overrides/main.ts +2

New file; Source code

high
tests/specs/npm/overrides/no_override/main.ts +2

New file; Source code

high
libs/resolver/factory.rs +36

Source code

medium
test_overrides_manual/package.json +9

New file; Configuration

medium
tests/specs/npm/overrides/package.json +10

New file; Configuration

medium
cli/lsp/resolver.rs +7

Source code

medium
libs/package_json/lib.rs +4

Source code

medium
libs/resolver/lockfile.rs +3

Source code

medium

+5 more files

Triage

51

minutes to review

high

effort level

none

staleness risk

Allocate focused review time

Recommendation

COMMENT 51.0% readiness

Some concerns to address before approval

Next Steps

Question

Why is tests_passing missing? Consider adding this check.

Question

Why is security_scan_clean missing? Consider adding this check.

Concern libs/config/workspace/mod.rs

Critical file: Modifies configuration code; 59 lines changed; Source code

Concern test_overrides_manual/main.ts

New file in high-priority area: New file; Source code

Concern tests/specs/npm/overrides/main.ts

New file in high-priority area: New file; Source code

Concern tests/specs/npm/overrides/no_override/main.ts

New file in high-priority area: New file; Source code

Suggestion

Verify new dependencies: @denotest/different-nested-dep, @denotest/different-nested-dep-child