Back

transformers #43772

[`Modular Dependencies`] Fixup qwen rms norms

by vasqu · Feb 06, 2026 at 19:26 UTC · scan-fdece802c6800041

View on Github · Download JSON
High Risk (70%)

Get this automatically on every PR

Install the Axiomo GitHub App to get Signals as check runs and PR comments on every pull request.

Install App

Risk Assessment

Risk level: High (70%)

Risk Drivers

  • high_file_spread: Touches 83 files
  • multiple_concerns: Spans 82 directories
  • missing_tests: Added 252 lines of code but only 0 lines of tests
  • api_surface_change: API surface changed in 81 file(s)

Intent

1/2 criteria met

Fix and standardize RMSNorm initialization with explicit type annotations.

Acceptance Criteria

  • ✓
    Ensure all RMSNorm initializations use explicit type annotations.

    All changed files add type annotations for `eps` and return type in RMSNorm classes.

  • ?
    Reduce weird dependencies by using proper imports.

    The description mentions dependencies, but changes only show type annotation adjustments.

Confidence: 90.0% Source: diff analysis AI: openai

Contributors

vasqu PR Author 5 commits + Trusted
Account Age: 1921 days
Prior PRs: 131
Merged: 112

Trusted contributor with 112 merged PRs. unfamiliar with 3 files.

Evidence

Evidence Completeness: 70.0%
tests_passing Passing
ci_passing Passing
build_successful Passing
Missing: lint_passing, security_scan_clean, coverage_maintained

Supply Chain

None Risk
Modifies dependencies
Modifies lockfile
Modifies CI config
Modifies build scripts

Focus Files

Review 83 file(s)

src/transformers/models/qwen2/modular_qwen2.py +34

Source code

medium
src/transformers/models/qwen2_5_omni/modeling_qwen2_5_omni.py +37

Source code

medium
src/transformers/models/qwen2_5_vl/modeling_qwen2_5_vl.py +35

Source code

medium
src/transformers/models/qwen2_vl/modeling_qwen2_vl.py +30

Source code

medium
src/transformers/models/glm4v_moe/modeling_glm4v_moe.py +8

Source code

medium
src/transformers/models/qwen2_5_vl/modular_qwen2_5_vl.py +12

Source code

medium
src/transformers/models/qwen3_omni_moe/modeling_qwen3_omni_moe.py +8

Source code

medium
src/transformers/models/afmoe/modeling_afmoe.py +4

Source code

medium
src/transformers/models/aimv2/modeling_aimv2.py +4

Source code

medium
src/transformers/models/apertus/modeling_apertus.py +4

Source code

medium

+73 more files

Triage

222

minutes to review

extensive

effort level

none

staleness risk

Schedule dedicated review time; consider pair review

Recommendation

COMMENT 62.0% readiness

Some concerns to address before approval

Next Steps

Question

Why is lint_passing missing? Consider adding this check.

Question

Why is security_scan_clean missing? Consider adding this check.